The statement had no effect. It's in a block intended for initialization (as shown in the line 639) so an assigment was probably the intended behaviour.
The graphical output is the same with or without this patch.
Detected by a warning from gcc:
spharm.c: In function ‘SpharmGenTest’:
spharm.c:640:15: warning: statement with no effect [-Wunused-value]
640 | objtype == 0;
| ~~~~~~~~^~~~
Fix several unused variables detected by gcc and displayed such as:
morphskin.c:270:37: warning: variable ‘ss’ set but not used [-Wunused-but-set-variable]
270 | float cs,ct,ss,st;
| ^~
morphskin.c:270:31: warning: variable ‘cs’ set but not used [-Wunused-but-set-variable]
270 | float cs,ct,ss,st;
| ^~
Fix several unused variables detected by gcc and displayed such as:
morphskin.c:270:37: warning: variable ‘ss’ set but not used [-Wunused-but-set-variable]
270 | float cs,ct,ss,st;
| ^~
morphskin.c:270:31: warning: variable ‘cs’ set but not used [-Wunused-but-set-variable]
270 | float cs,ct,ss,st;
| ^~
Hexadecimal constants are replaced by the same value, defined by the FRAME_SIZE macro. These changes are based on the same replacement already done in clut.c.
- Fix sceGuBreak
- Fix sceGuContinue
- Fix sceGuDrawArrayN
- Fix sceGuMorphWeight
- Remove unnecessary 0xffffff as it is done by sendCommandi
- Improve the name of some parameters
- Create and use GU_MAX_STATUS
- Remove magic numbers in `sceGuMaterial`
- Remove magic numbers in `sceGuMorphWeight`
- Remove magic numbers in `sceGuSetMatrix`
- Remove magic numbers in `sceGuSignal`
The Code of Conduct (CoC) was not included in the documentation generated by Doxyfile.
With this patch, the CoC is included, the link in the index exists and this warning is fixed:
[...]README.md:160: warning: unable to resolve reference to '/home/stephane/src/pspsdk/CODE_OF_CONDUCT.md' for \ref command
The documentation generated by Doxygen moves from doc/ to doc/build/.
There is a problem with using doc/ directory because when Doxygen produces the documentation, the doc/ directory is replaced so its content (style.css file) disappears.
When Doxygen generates the documentation (via `make doxygen-run`), it displays warnings such as:
warning: Tag 'OUTPUT_TEXT_DIRECTION' at line 102 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
The patch contains only the modifications done by `doxygen -u`.
