The statement had no effect. It's in a block intended for initialization (as shown in the line 639) so an assigment was probably the intended behaviour.
The graphical output is the same with or without this patch.
Detected by a warning from gcc:
spharm.c: In function ‘SpharmGenTest’:
spharm.c:640:15: warning: statement with no effect [-Wunused-value]
640 | objtype == 0;
| ~~~~~~~~^~~~
Fix several unused variables detected by gcc and displayed such as:
morphskin.c:270:37: warning: variable ‘ss’ set but not used [-Wunused-but-set-variable]
270 | float cs,ct,ss,st;
| ^~
morphskin.c:270:31: warning: variable ‘cs’ set but not used [-Wunused-but-set-variable]
270 | float cs,ct,ss,st;
| ^~
Fix several unused variables detected by gcc and displayed such as:
morphskin.c:270:37: warning: variable ‘ss’ set but not used [-Wunused-but-set-variable]
270 | float cs,ct,ss,st;
| ^~
morphskin.c:270:31: warning: variable ‘cs’ set but not used [-Wunused-but-set-variable]
270 | float cs,ct,ss,st;
| ^~
Hexadecimal constants are replaced by the same value, defined by the FRAME_SIZE macro. These changes are based on the same replacement already done in clut.c.
- Fix sceGuBreak
- Fix sceGuContinue
- Fix sceGuDrawArrayN
- Fix sceGuMorphWeight
- Remove unnecessary 0xffffff as it is done by sendCommandi
- Improve the name of some parameters
- Create and use GU_MAX_STATUS
- Remove magic numbers in `sceGuMaterial`
- Remove magic numbers in `sceGuMorphWeight`
- Remove magic numbers in `sceGuSetMatrix`
- Remove magic numbers in `sceGuSignal`
This patch fixes the search for function like __mcount() or gprof_start().
The issue existed for functions with function attribute (__attribute__()): Doxygen didn't parsed it properly. It fixes such warnings:
warning: documented symbol '__mcount' was not declared or defined.
After changing Doxygen configuration to fix it, new warnings appears. For example:
warning: explicit link request to 'PSP_VAUDIO_FORMAT_' could not be resolved
It's fixed by using the full name of the constants. By the way, it also fixes the link to the constants in the documentation.
Initial patch based on:
https://stackoverflow.com/questions/75410662/doxygen-does-not-parse-attribute-correctly
Doxygen displays two warnings (among others) because parameters filled in @params are not correct.
The warnings fixed are:
pspsdk/src/user/pspthreadman.h:622: warning: argument 'optionsPTr' of command @param is not found in the argument list of sceKernelCreateLwMutex(SceLwMutexWorkarea *workarea, const char *name, SceUInt32 attr, int initialCount, u32 *optionsPtr)
pspsdk/src/user/pspthreadman.h:622: warning: The following parameter of sceKernelCreateLwMutex(SceLwMutexWorkarea *workarea, const char *name, SceUInt32 attr, int initialCount, u32 *optionsPtr) is not documented:
parameter 'optionsPtr'
pspsdk/src/user/pspthreadman.h:665: warning: argument 'name' of command @param is not found in the argument list of sceKernelUnlockLwMutex(SceLwMutexWorkarea *workarea, int lockCount)
