The statement had no effect. It's in a block intended for initialization (as shown in the line 639) so an assigment was probably the intended behaviour.
The graphical output is the same with or without this patch.
Detected by a warning from gcc:
spharm.c: In function ‘SpharmGenTest’:
spharm.c:640:15: warning: statement with no effect [-Wunused-value]
640 | objtype == 0;
| ~~~~~~~~^~~~
Fix several unused variables detected by gcc and displayed such as:
morphskin.c:270:37: warning: variable ‘ss’ set but not used [-Wunused-but-set-variable]
270 | float cs,ct,ss,st;
| ^~
morphskin.c:270:31: warning: variable ‘cs’ set but not used [-Wunused-but-set-variable]
270 | float cs,ct,ss,st;
| ^~
Fix several unused variables detected by gcc and displayed such as:
morphskin.c:270:37: warning: variable ‘ss’ set but not used [-Wunused-but-set-variable]
270 | float cs,ct,ss,st;
| ^~
morphskin.c:270:31: warning: variable ‘cs’ set but not used [-Wunused-but-set-variable]
270 | float cs,ct,ss,st;
| ^~
Hexadecimal constants are replaced by the same value, defined by the FRAME_SIZE macro. These changes are based on the same replacement already done in clut.c.
When the SceCtrlData.Lx value changes, the length of the value can change (from 1 character to 3 characters) so the string for Ly moves to the right by one or two characters.
The SceCtrlData.Lx and Ly are `unsigned char` so the value are between 0 (one character length) and 255 (3 characters length).
It's more readable by fixing the size for the value to 3 characters wide so the string to Ly does not move.
* Fix htmlviewer sample
* Uses PSP_HEAP_THRESHOLD_SIZE_KB macro instead of defining a fixed heap size
* Revert to original htmlviewer sample and apply minimal fixes only
---------
Co-authored-by: Bas van den Aakster <bas@xtr.dev>
fix for PR
renamed logo folder to image_display, renamed logo to image in source, changed image used, removed FW version from makefile, added header to source, added image_display to all samples makefile
Fixes#123. Guards `_PSP_FW_VERSION` references with `#if defined()` to avoid the SDK headers returning warnings when compiling modules with the `-Wundef` cflag.
