External/cglm
1
0
Fork 0
mirror of https://github.com/recp/cglm.git synced 2025-12-25 04:44:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #207 from legends2k/fix_vec3_ortho

Browse Source 
Fix vec3_ortho
This commit is contained in:
Recep Aslantas
2021-06-10 10:15:12 +03:00
committed by GitHub
parent afdcae08dd 38c6188e12
commit 479e7d4240
4 changed files with 20 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
docs/source/vec3.rst
View File

@@ -474,6 +474,9 @@ Functions documentation
possible orthogonal/perpendicular vector
References:
* `On picking an orthogonal vector (and combing coconuts) <http://lolengine.net/blog/2013/09/21/picking-orthogonal-vector-combing-coconuts>`_
Parameters:
| *[in]* **v** vector
| *[out]* **dest** orthogonal/perpendicular vector

7
include/cglm/vec3.h
View File

@@ -807,9 +807,10 @@ glm_vec3_minv(vec3 a, vec3 b, vec3 dest) {
CGLM_INLINE
void
glm_vec3_ortho(vec3 v, vec3 dest) {
dest[0] = v[1] - v[2];
dest[1] = v[2] - v[0];
dest[2] = v[0] - v[1];
float ignore;
float f = modff(fabsf(v[0]) + 0.5f, &ignore);
vec3 result = {-v[1], v[0] - f * v[2], f * v[1]};
glm_vec3_copy(result, dest);
}
/*!

12
test/runner.c
View File

@@ -79,22 +79,20 @@ main(int argc, const char * argv[]) {
if (failed == 0) {
fprintf(stderr,
BOLDGREEN "\n All tests are passed " FINAL_TEXT "\n" RESET);
BOLDGREEN "\n All tests passed " FINAL_TEXT "\n" RESET);
}
fprintf(stderr,
CYAN "\ncglm test results (%0.2fs):\n" RESET
"--------------------------\n"
MAGENTA "%d" RESET " tests are runned, "
GREEN "%d" RESET " %s passed, "
RED "%d" RESET " %s failed\n\n" RESET,
MAGENTA "%d" RESET " tests ran, "
GREEN "%d" RESET " passed, "
RED "%d" RESET " failed\n\n" RESET,
total,
count,
passed,
passed > 1 ? "are" : "is",
failed,
failed > 1 ? "are" : "is");
failed);
return failed;
}

10
test/src/test_vec3.h
View File

@@ -1123,8 +1123,8 @@ TEST_IMPL(GLM_PREFIX, vec3_minv) {
}
TEST_IMPL(GLM_PREFIX, vec3_ortho) {
vec3 v1, v2, v3;
vec3 v5, v6, v7;
vec3 v1, v2, v3, v4 = {1.f, 1.f, 1.f};
vec3 v5, v6, v7, v8;
float a;
test_rand_vec3(v1);
@@ -1134,6 +1134,7 @@ TEST_IMPL(GLM_PREFIX, vec3_ortho) {
GLM(vec3_ortho)(v1, v5);
GLM(vec3_ortho)(v2, v6);
GLM(vec3_ortho)(v3, v7);
GLM(vec3_ortho)(v4, v8);
a = glm_vec3_angle(v1, v5);
ASSERT(!isinf(a))
@@ -1150,6 +1151,11 @@ TEST_IMPL(GLM_PREFIX, vec3_ortho) {
ASSERT(!isnan(a))
ASSERT(test_eq(a, GLM_PI_2f))
a = glm_vec3_angle(v4, v8);
ASSERT(!isinf(a))
ASSERT(!isnan(a))
ASSERT(test_eq(a, GLM_PI_2f))
TEST_SUCCESS
}