External/cglm
1
0
Fork 0
mirror of https://github.com/recp/cglm.git synced 2025-10-03 16:51:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

vec: improve angle between two vector

Browse Source 
* because `acosf()` may return NaN if cosine/dot is out of range
This commit is contained in:
Recep Aslantas
2018-11-28 14:48:12 +03:00
parent 9af61d2101
commit ef6134263e
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
include/cglm/vec3.h
View File

@@ -548,11 +548,18 @@ glm_vec_normalize_to(vec3 vec, vec3 dest) {
CGLM_INLINE
float
glm_vec_angle(vec3 v1, vec3 v2) {
float norm;
float norm, dot;
/* maybe compiler generate approximation instruction (rcp) */
norm = 1.0f / (glm_vec_norm(v1) * glm_vec_norm(v2));
return acosf(glm_vec_dot(v1, v2) * norm);
dot = glm_vec_dot(v1, v2) * norm;
if (dot > 1.0f)
return 0.0f;
else if (dot < -1.0f)
return CGLM_PI;
return acosf(dot);
}
/*!