From c6d07bb6eb036742c25bdad9b8ccb6d74871cb64 Mon Sep 17 00:00:00 2001 From: Recep Aslantas Date: Thu, 10 May 2018 12:18:54 +0300 Subject: [PATCH] surround PI with parentheses + code style + update docs --- docs/source/getting_started.rst | 4 ++-- docs/source/troubleshooting.rst | 2 +- include/cglm/simd/sse2/affine.h | 2 +- include/cglm/types.h | 10 +++++----- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/source/getting_started.rst b/docs/source/getting_started.rst index 05c4440..2f8511c 100644 --- a/docs/source/getting_started.rst +++ b/docs/source/getting_started.rst @@ -28,11 +28,11 @@ Alignment is Required: vectorized by SIMD instructions (SSE/AVX). **UPDATE:** - By starting v0.4.5 cglm provides an option to disable alignment requirement, it is enabled as default + By starting v0.4.5 cglm provides an option to disable alignment requirement, it is enabled as default | Check :doc:`opt` page for more details - Also alignment is disabled for older msvc verisons as default. Now alignment only is required in Visual Studio 2017 version 15.6+ if CGLM_ALL_UNALIGNED macro is not defined. + Also alignment is disabled for older msvc verisons as default. Now alignment is only required in Visual Studio 2017 version 15.6+ if CGLM_ALL_UNALIGNED macro is not defined. Allocations: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/docs/source/troubleshooting.rst b/docs/source/troubleshooting.rst index 7c416b0..c897dc2 100644 --- a/docs/source/troubleshooting.rst +++ b/docs/source/troubleshooting.rst @@ -44,7 +44,7 @@ you may do it yourself. **This MSVC issue is still in TODOs.** **UPDATE:** By starting v0.4.5 cglm provides an option to disable alignment requirement. -Also alignment is disabled for older msvc verisons as default. Now alignment only is required in Visual Studio 2017 version 15.6+ if CGLM_ALL_UNALIGNED macro is defined. +Also alignment is disabled for older msvc verisons as default. Now alignment is only required in Visual Studio 2017 version 15.6+ if CGLM_ALL_UNALIGNED macro is not defined. Crashes, Invalid Memory Access: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/include/cglm/simd/sse2/affine.h b/include/cglm/simd/sse2/affine.h index c0c9c04..8a644d3 100644 --- a/include/cglm/simd/sse2/affine.h +++ b/include/cglm/simd/sse2/affine.h @@ -90,7 +90,7 @@ glm_inv_tr_sse2(mat4 mat) { r1 = glmm_load(mat[1]); r2 = glmm_load(mat[2]); r3 = glmm_load(mat[3]); - x1 = _mm_set_ps(1.0f, 0.0f, 0.0f, 0.0f); + x1 = _mm_set_ps(1.0f, 0.0f, 0.0f, 0.0f); _MM_TRANSPOSE4_PS(r0, r1, r2, x1); diff --git a/include/cglm/types.h b/include/cglm/types.h index 99226df..d470e7b 100644 --- a/include/cglm/types.h +++ b/include/cglm/types.h @@ -27,17 +27,17 @@ #endif typedef float vec2[2]; -typedef CGLM_ALIGN_IF(8) float vec3[3]; +typedef CGLM_ALIGN_IF(8) float vec3[3]; typedef int ivec3[3]; typedef CGLM_ALIGN_IF(16) float vec4[4]; -typedef vec3 mat3[3]; +typedef vec3 mat3[3]; typedef CGLM_ALIGN_IF(16) vec4 mat4[4]; typedef vec4 versor; -#define CGLM_PI (float)M_PI -#define CGLM_PI_2 (float)M_PI_2 -#define CGLM_PI_4 (float)M_PI_4 +#define CGLM_PI ((float)M_PI) +#define CGLM_PI_2 ((float)M_PI_2) +#define CGLM_PI_4 ((float)M_PI_4) #endif /* cglm_types_h */