From af5a2627b4566eabd44058d219f31dd8debb1e58 Mon Sep 17 00:00:00 2001 From: Recep Aslantas Date: Fri, 13 Apr 2018 11:57:34 +0300 Subject: [PATCH] fix scale_as for zero length vector * return zero if vector length is zero --- include/cglm/vec3.h | 4 ++-- include/cglm/vec4.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/cglm/vec3.h b/include/cglm/vec3.h index 6f42855..2be7173 100644 --- a/include/cglm/vec3.h +++ b/include/cglm/vec3.h @@ -247,8 +247,8 @@ glm_vec_scale_as(vec3 v, float s, vec3 dest) { float norm; norm = glm_vec_norm(v); - if (norm == 0) { - glm_vec_copy(v, dest); + if (norm == 0.0f) { + glm_vec_zero(dest); return; } diff --git a/include/cglm/vec4.h b/include/cglm/vec4.h index 44c6a31..b28d9fd 100644 --- a/include/cglm/vec4.h +++ b/include/cglm/vec4.h @@ -291,8 +291,8 @@ glm_vec4_scale_as(vec4 v, float s, vec4 dest) { float norm; norm = glm_vec4_norm(v); - if (norm == 0) { - glm_vec4_copy(v, dest); + if (norm == 0.0f) { + glm_vec4_zero(dest); return; }