External/cglm
1
0
Fork 0
mirror of https://github.com/recp/cglm.git synced 2025-10-04 09:08:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

struct: fix glms_perspective_resize

Browse Source 
since struct param is copy-by-value, result was noop
This commit is contained in:
Recep Aslantas
2021-05-30 13:06:49 +03:00
parent 0e794f8f8f
commit 94381d3067
5 changed files with 45 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
include/cglm/struct/cam.h
View File

@@ -322,20 +322,24 @@ glms_perspective_default(float aspect) {
* this makes very easy to resize proj matrix when window /viewport * this makes very easy to resize proj matrix when window /viewport
* reized * reized
* *
* NOTE: if you dodn't want to create new matrix then use array api on struct.raw
* like glms_perspective_resize(proj.raw, aspect) to avoid create new mat4
* each time
*
* @param[in, out] proj perspective projection matrix * @param[in, out] proj perspective projection matrix
* @param[in] aspect aspect ratio ( width / height ) * @param[in] aspect aspect ratio ( width / height )
*/ */
CGLM_INLINE CGLM_INLINE
void mat4s
glms_perspective_resize(mat4s proj, float aspect) { glms_perspective_resize(mat4s proj, float aspect) {
#if CGLM_CONFIG_CLIP_CONTROL == CGLM_CLIP_CONTROL_LH_ZO #if CGLM_CONFIG_CLIP_CONTROL == CGLM_CLIP_CONTROL_LH_ZO
glms_perspective_resize_lh_zo(proj, aspect); return glms_perspective_resize_lh_zo(proj, aspect);
#elif CGLM_CONFIG_CLIP_CONTROL == CGLM_CLIP_CONTROL_LH_NO #elif CGLM_CONFIG_CLIP_CONTROL == CGLM_CLIP_CONTROL_LH_NO
glms_perspective_resize_lh_no(proj, aspect); return glms_perspective_resize_lh_no(proj, aspect);
#elif CGLM_CONFIG_CLIP_CONTROL == CGLM_CLIP_CONTROL_RH_ZO #elif CGLM_CONFIG_CLIP_CONTROL == CGLM_CLIP_CONTROL_RH_ZO
glms_perspective_resize_rh_zo(proj, aspect); return glms_perspective_resize_rh_zo(proj, aspect);
#elif CGLM_CONFIG_CLIP_CONTROL == CGLM_CLIP_CONTROL_RH_NO #elif CGLM_CONFIG_CLIP_CONTROL == CGLM_CLIP_CONTROL_RH_NO
glms_perspective_resize_rh_no(proj, aspect); return glms_perspective_resize_rh_no(proj, aspect);
#endif #endif
} }

11
include/cglm/struct/clipspace/persp_lh_no.h
View File

@@ -127,13 +127,20 @@ glms_perspective_default_lh_no(float aspect) {
* reized with a left-hand coordinate system and a * reized with a left-hand coordinate system and a
* clip-space of [-1, 1]. * clip-space of [-1, 1].
* *
* NOTE: if you dodn't want to create new matrix then use array api on struct.raw
* like glm_perspective_resize_lh_no(proj.raw, aspect) to avoid create new mat4
* each time
*
* @param[in, out] proj perspective projection matrix * @param[in, out] proj perspective projection matrix
* @param[in] aspect aspect ratio ( width / height ) * @param[in] aspect aspect ratio ( width / height )
*/ */
CGLM_INLINE CGLM_INLINE
void mat4s
glms_perspective_resize_lh_no(mat4s proj, float aspect) { glms_perspective_resize_lh_no(mat4s proj, float aspect) {
glm_perspective_resize_lh_no(aspect, proj.raw); mat4s dest;
dest = proj;
glm_perspective_resize_lh_no(aspect, dest.raw);
return dest;
} }
/*! /*!

11
include/cglm/struct/clipspace/persp_lh_zo.h
View File

@@ -127,13 +127,20 @@ glms_perspective_default_lh_zo(float aspect) {
* reized with a left-hand coordinate system and a * reized with a left-hand coordinate system and a
* clip-space of [0, 1]. * clip-space of [0, 1].
* *
* NOTE: if you dodn't want to create new matrix then use array api on struct.raw
* like glms_perspective_resize_lh_zo(proj.raw, aspect) to avoid create new mat4
* each time
*
* @param[in, out] proj perspective projection matrix * @param[in, out] proj perspective projection matrix
* @param[in] aspect aspect ratio ( width / height ) * @param[in] aspect aspect ratio ( width / height )
*/ */
CGLM_INLINE CGLM_INLINE
void mat4s
glms_perspective_resize_lh_zo(mat4s proj, float aspect) { glms_perspective_resize_lh_zo(mat4s proj, float aspect) {
glm_perspective_resize_lh_zo(aspect, proj.raw); mat4s dest;
dest = proj;
glm_perspective_resize_lh_zo(aspect, dest.raw);
return dest;
} }
/*! /*!

11
include/cglm/struct/clipspace/persp_rh_no.h
View File

@@ -127,13 +127,20 @@ glms_perspective_default_rh_no(float aspect) {
* reized with a right-hand coordinate system and a * reized with a right-hand coordinate system and a
* clip-space of [-1, 1]. * clip-space of [-1, 1].
* *
* NOTE: if you dodn't want to create new matrix then use array api on struct.raw
* like glm_perspective_resize_rh_no(proj.raw, aspect) to avoid create new mat4
* each time
*
* @param[in, out] proj perspective projection matrix * @param[in, out] proj perspective projection matrix
* @param[in] aspect aspect ratio ( width / height ) * @param[in] aspect aspect ratio ( width / height )
*/ */
CGLM_INLINE CGLM_INLINE
void mat4s
glms_perspective_resize_rh_no(mat4s proj, float aspect) { glms_perspective_resize_rh_no(mat4s proj, float aspect) {
glm_perspective_resize_rh_no(aspect, proj.raw); mat4s dest;
dest = proj;
glm_perspective_resize_rh_no(aspect, dest.raw);
return dest;
} }
/*! /*!

11
include/cglm/struct/clipspace/persp_rh_zo.h
View File

@@ -127,13 +127,20 @@ glms_perspective_default_rh_zo(float aspect) {
* reized with a right-hand coordinate system and a * reized with a right-hand coordinate system and a
* clip-space of [0, 1]. * clip-space of [0, 1].
* *
* NOTE: if you dodn't want to create new matrix then use array api on struct.raw
* like glm_perspective_resize_rh_zo(proj.raw, aspect) to avoid create new mat4
* each time
*
* @param[in, out] proj perspective projection matrix * @param[in, out] proj perspective projection matrix
* @param[in] aspect aspect ratio ( width / height ) * @param[in] aspect aspect ratio ( width / height )
*/ */
CGLM_INLINE CGLM_INLINE
void mat4s
glms_perspective_resize_rh_zo(mat4s proj, float aspect) { glms_perspective_resize_rh_zo(mat4s proj, float aspect) {
glm_perspective_resize_rh_zo(aspect, proj.raw); mat4s dest;
dest = proj;
glm_perspective_resize_rh_zo(aspect, dest.raw);
return dest;
} }
/*! /*!