From 92605f845abaa7707f2e7666caefdc57f14923d6 Mon Sep 17 00:00:00 2001 From: Recep Aslantas Date: Wed, 5 Dec 2018 16:34:22 +0300 Subject: [PATCH] test: fix comparing two float values in tests --- include/cglm/vec3.h | 2 +- include/cglm/vec4.h | 8 ++++---- test/src/test_mat3.c | 4 ++-- test/src/test_mat4.c | 4 ++-- test/src/test_quat.c | 4 ++-- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/include/cglm/vec3.h b/include/cglm/vec3.h index 04d697b..e5994ba 100644 --- a/include/cglm/vec3.h +++ b/include/cglm/vec3.h @@ -444,7 +444,7 @@ glm_vec3_maxadd(vec3 a, vec3 b, vec3 dest) { * it applies += operator so dest must be initialized * * @param[in] a vector - * @param[in] s scalar + * @param[in] b scalar * @param[out] dest dest += min(a, b) */ CGLM_INLINE diff --git a/include/cglm/vec4.h b/include/cglm/vec4.h index 5391047..97a915b 100644 --- a/include/cglm/vec4.h +++ b/include/cglm/vec4.h @@ -331,9 +331,9 @@ glm_vec4_subs(vec4 v, float s, vec4 dest) { /*! * @brief multiply two vector (component-wise multiplication) * - * @param a vector1 - * @param b vector2 - * @param d dest = (a[0] * b[0], a[1] * b[1], a[2] * b[2], a[3] * b[3]) + * @param a vector1 + * @param b vector2 + * @param dest dest = (a[0] * b[0], a[1] * b[1], a[2] * b[2], a[3] * b[3]) */ CGLM_INLINE void @@ -553,7 +553,7 @@ glm_vec4_maxadd(vec4 a, vec4 b, vec4 dest) { * it applies += operator so dest must be initialized * * @param[in] a vector - * @param[in] s scalar + * @param[in] b scalar * @param[out] dest dest += min(a, b) */ CGLM_INLINE diff --git a/test/src/test_mat3.c b/test/src/test_mat3.c index d97d1f5..e0de7c6 100644 --- a/test/src/test_mat3.c +++ b/test/src/test_mat3.c @@ -24,9 +24,9 @@ test_mat3(void **state) { for (i = 0; i < m; i++) { for (j = 0; j < n; j++) { if (i == j) - assert_true(m3[i][j] == 1.0f); + assert_true(glm_eq(m3[i][j], 1.0f)); else - assert_true(m3[i][j] == 0.0f); + assert_true(glm_eq(m3[i][j], 0.0f)); } } diff --git a/test/src/test_mat4.c b/test/src/test_mat4.c index 7e4c488..f369829 100644 --- a/test/src/test_mat4.c +++ b/test/src/test_mat4.c @@ -24,9 +24,9 @@ test_mat4(void **state) { for (i = 0; i < m; i++) { for (j = 0; j < n; j++) { if (i == j) - assert_true(m3[i][j] == 1.0f); + assert_true(glm_eq(m3[i][j], 1.0f)); else - assert_true(m3[i][j] == 0.0f); + assert_true(glm_eq(m3[i][j], 0.0f)); } } diff --git a/test/src/test_quat.c b/test/src/test_quat.c index 62e2306..0d64367 100644 --- a/test/src/test_quat.c +++ b/test/src/test_quat.c @@ -25,7 +25,7 @@ test_quat(void **state) { /* 0. test identiy quat */ glm_quat_identity(q4); - assert_true(glm_quat_real(q4) == cosf(glm_rad(0.0f) * 0.5f)); + assert_true(glm_eq(glm_quat_real(q4), cosf(glm_rad(0.0f) * 0.5f))); glm_quat_mat4(q4, rot1); test_assert_mat4_eq2(rot1, GLM_MAT4_IDENTITY, 0.000009); @@ -118,7 +118,7 @@ test_quat(void **state) { /* 9. test imag, real */ /* 9.1 real */ - assert_true(glm_quat_real(q4) == cosf(glm_rad(-90.0f) * 0.5f)); + assert_true(glm_eq(glm_quat_real(q4), cosf(glm_rad(-90.0f) * 0.5f))); /* 9.1 imag */ glm_quat_imag(q4, imag);