From e463edb185b0a65e0e170e96a8ea6842073aebc7 Mon Sep 17 00:00:00 2001
From: arthomnix <arthomnix@arthomnix.dev>
Date: Sun, 5 Feb 2023 15:55:49 +0000
Subject: [PATCH] GH-4699 Warn when exporting instance with custom components

---
 launcher/ui/dialogs/ModrinthExportDialog.cpp | 32 ++++++++++----------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/launcher/ui/dialogs/ModrinthExportDialog.cpp b/launcher/ui/dialogs/ModrinthExportDialog.cpp
index 4b0d3682..58db2322 100644
--- a/launcher/ui/dialogs/ModrinthExportDialog.cpp
+++ b/launcher/ui/dialogs/ModrinthExportDialog.cpp
@@ -89,23 +89,23 @@ void ModrinthExportDialog::accept()
     MinecraftInstancePtr minecraftInstance = std::dynamic_pointer_cast<MinecraftInstance>(m_instance);
     minecraftInstance->getPackProfile()->reload(Net::Mode::Offline);
 
-    auto minecraftComponent = minecraftInstance->getPackProfile()->getComponent("net.minecraft");
-    auto forgeComponent = minecraftInstance->getPackProfile()->getComponent("net.minecraftforge");
-    auto fabricComponent = minecraftInstance->getPackProfile()->getComponent("net.fabricmc.fabric-loader");
-    auto quiltComponent = minecraftInstance->getPackProfile()->getComponent("org.quiltmc.quilt-loader");
+    for (int i = 0; i < minecraftInstance->getPackProfile()->rowCount(); i++) {
+        auto component = minecraftInstance->getPackProfile()->getComponent(i);
+        if (component->isCustom()) {
+            CustomMessageBox::selectable(
+                    this,
+                    tr("Warning"),
+                    tr("Instance contains a custom component: %1\nThis cannot be exported to a Modrinth pack; the exported pack may not work correctly!")
+                        .arg(component->getName()),
+                    QMessageBox::Warning
+            )->exec();
+        }
+    }
 
-    if (minecraftComponent) {
-        settings.gameVersion = minecraftComponent->getVersion();
-    }
-    if (forgeComponent) {
-        settings.forgeVersion = forgeComponent->getVersion();
-    }
-    if (fabricComponent) {
-        settings.fabricVersion = fabricComponent->getVersion();
-    }
-    if (quiltComponent) {
-        settings.quiltVersion = quiltComponent->getVersion();
-    }
+    settings.gameVersion = minecraftInstance->getPackProfile()->getComponentVersion("net.minecraft");
+    settings.forgeVersion = minecraftInstance->getPackProfile()->getComponentVersion("net.minecraftforge");
+    settings.fabricVersion = minecraftInstance->getPackProfile()->getComponentVersion("net.fabricmc.fabric-loader");
+    settings.forgeVersion = minecraftInstance->getPackProfile()->getComponentVersion("org.quiltmc.quilt-loader");
 
     settings.exportPath = ui->file->text();