diff --git a/launcher/CMakeLists.txt b/launcher/CMakeLists.txt index e3ef5039..37f5d3a1 100644 --- a/launcher/CMakeLists.txt +++ b/launcher/CMakeLists.txt @@ -918,8 +918,10 @@ endif() if(DEFINED MultiMC_BINARY_RPATH) SET_TARGET_PROPERTIES(MultiMC PROPERTIES INSTALL_RPATH "${MultiMC_BINARY_RPATH}") endif() + if(DEFINED MultiMC_APP_BINARY_DEFS) target_compile_definitions(MultiMC PRIVATE ${MultiMC_APP_BINARY_DEFS}) + target_compile_definitions(MultiMC_logic PRIVATE ${MultiMC_APP_BINARY_DEFS}) endif() install(TARGETS MultiMC diff --git a/launcher/minecraft/auth/AuthSession.h b/launcher/minecraft/auth/AuthSession.h index e806cd6f..0d875e2a 100644 --- a/launcher/minecraft/auth/AuthSession.h +++ b/launcher/minecraft/auth/AuthSession.h @@ -4,8 +4,6 @@ #include #include -#include "logic_export.h" - class MojangAccount; struct User diff --git a/launcher/minecraft/auth/MojangAccountList.h b/launcher/minecraft/auth/MojangAccountList.h index 90bcf607..fba7e713 100644 --- a/launcher/minecraft/auth/MojangAccountList.h +++ b/launcher/minecraft/auth/MojangAccountList.h @@ -7,6 +7,15 @@ #include #include +/*! + * \brief List of available Mojang accounts. + * This should be loaded in the background by MultiMC on startup. + * + * This class also inherits from QAbstractListModel. Methods from that + * class determine how this list shows up in a list view. Said methods + * all have a default implementation, but they can be overridden by subclasses to + * change the behavior of the list. + */ class MojangAccountList : public QAbstractListModel { Q_OBJECT