From 79a8e26406f01a664890461aa0b7addcefb72ba7 Mon Sep 17 00:00:00 2001 From: Sebastian-byte Date: Tue, 23 Mar 2021 14:01:45 -0500 Subject: [PATCH 1/3] Revert "NOISSUE add github issue forms" This reverts commit 613afce7055e4b106a322bf5e4163c05bdbc337f. --- .github/ISSUE_TEMPLATE.md | 51 ++++++++++++++++++++++++++ .github/ISSUE_TEMPLATE/bug_report.yml | 52 --------------------------- .github/ISSUE_TEMPLATE/config.yml | 5 --- .github/ISSUE_TEMPLATE/suggestion.yml | 41 --------------------- 4 files changed, 51 insertions(+), 98 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE.md delete mode 100644 .github/ISSUE_TEMPLATE/bug_report.yml delete mode 100644 .github/ISSUE_TEMPLATE/config.yml delete mode 100644 .github/ISSUE_TEMPLATE/suggestion.yml diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md new file mode 100644 index 00000000..58596fa0 --- /dev/null +++ b/.github/ISSUE_TEMPLATE.md @@ -0,0 +1,51 @@ + + +System Information +----------------------------- +MultiMC version: + +Operating System: + +Summary of the issue or suggestion: +---------------------------------------------- + + +What should happen: +------------------------------ + + +Steps to reproduce the issue (Add more if needed): +------------------------------------------------------------- +1. + +2. + +3. + +Suspected cause: +--------------------------- + + +Logs/Screenshots: +---------------------------- +[//]: # (Please refer to https://github.com/MultiMC/MultiMC5/wiki/Log-Upload for instructions on how to attach your logs.) + + +Additional Info: +--------------------------- diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml deleted file mode 100644 index 7e894785..00000000 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ /dev/null @@ -1,52 +0,0 @@ -name: Bug Report -description: File a bug report -labels: [bug, needs-triage] -issue_body: false -body: -- type: markdown - attributes: - value: | - If you need help with running Minecraft, please visit us [on our Discord](https://discord.gg/multimc) before making a bug report. - - Before submitting a bug report, please make sure you have read this *entire* form, and that: - * You have read the [FAQ](https://github.com/MultiMC/MultiMC5/wiki/FAQ) and it has not answered your question - * Your bug is not caused by Minecraft or any mods you have installed. - * Your issue has not been reported before, [make sure to use the search function!](https://github.com/MultiMC/MultiMC5/issues) - - **Do not forget to give your issue a descriptive title.** "Bug in the instance screen" makes it hard to distinguish issues at a glance. -- type: dropdown - attributes: - label: Operating System - description: If you know this bug occurs on multiple operating systems, select all you have tested. - multiple: true - options: - - Windows - - macOS - - Linux - - Other -- type: textarea - attributes: - label: Description of bug - description: What did you expect to happen, what happened, and why is it incorrect? - placeholder: The cat button should show a cat, but it showed a dog instead! - validations: - required: true -- type: textarea - attributes: - label: Steps to reproduce - description: A bulleted list, or an exported instance if relevant. - placeholder: "* Press the cat button" - validations: - required: true -- type: textarea - attributes: - label: Suspected cause - description: If you know what could be causing this bug, describe it here. - validations: - required: false -- type: checkboxes - attributes: - label: This issue is unique - options: - - label: I have searched the issue tracker and did not find an issue describing my bug. - required: true diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml deleted file mode 100644 index 089f1eb5..00000000 --- a/.github/ISSUE_TEMPLATE/config.yml +++ /dev/null @@ -1,5 +0,0 @@ -blank_issues_enabled: true -contact_links: - - name: MultiMC Discord - url: https://discord.gg/multimc - about: Please ask for support here before opening an issue. diff --git a/.github/ISSUE_TEMPLATE/suggestion.yml b/.github/ISSUE_TEMPLATE/suggestion.yml deleted file mode 100644 index ab2449a0..00000000 --- a/.github/ISSUE_TEMPLATE/suggestion.yml +++ /dev/null @@ -1,41 +0,0 @@ -name: Suggestion -description: Make a suggestion -labels: [idea, needs-triage] -issue_body: true -body: -- type: markdown - attributes: - value: | - ### Use this form to suggest a feature for MultiMC. -- type: input - attributes: - label: Role - description: In what way do you use MultiMC that needs this feature? - placeholder: I play modded Minecraft. - validations: - required: true -- type: input - attributes: - label: Suggestion - description: What do you want MultiMC to do? - placeholder: I want the cat button to meow. - validations: - required: true -- type: input - attributes: - label: Benefit - description: Why do you need MultiMC to do this? - placeholder: so that I can always hear a cat when I need to. - validations: - required: true -- type: checkboxes - attributes: - label: This suggestion is unique - options: - - label: I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected. - required: true -- type: markdown - attributes: - value: | - ### You may use the editor below to elaborate further. -# The issue_body: true up there makes the standard WYSIWYG editor for issues show up down here. From 183f7f3324d4cd6f0bed30c115ae0e5b26a782bc Mon Sep 17 00:00:00 2001 From: Sebastian-byte Date: Tue, 23 Mar 2021 14:05:27 -0500 Subject: [PATCH 2/3] Revert "Revert "NOISSUE add github issue forms"" This reverts commit 79a8e26406f01a664890461aa0b7addcefb72ba7. --- .github/ISSUE_TEMPLATE.md | 51 -------------------------- .github/ISSUE_TEMPLATE/bug_report.yml | 52 +++++++++++++++++++++++++++ .github/ISSUE_TEMPLATE/config.yml | 5 +++ .github/ISSUE_TEMPLATE/suggestion.yml | 41 +++++++++++++++++++++ 4 files changed, 98 insertions(+), 51 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE.md create mode 100644 .github/ISSUE_TEMPLATE/bug_report.yml create mode 100644 .github/ISSUE_TEMPLATE/config.yml create mode 100644 .github/ISSUE_TEMPLATE/suggestion.yml diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md deleted file mode 100644 index 58596fa0..00000000 --- a/.github/ISSUE_TEMPLATE.md +++ /dev/null @@ -1,51 +0,0 @@ - - -System Information ------------------------------ -MultiMC version: - -Operating System: - -Summary of the issue or suggestion: ----------------------------------------------- - - -What should happen: ------------------------------- - - -Steps to reproduce the issue (Add more if needed): -------------------------------------------------------------- -1. - -2. - -3. - -Suspected cause: ---------------------------- - - -Logs/Screenshots: ----------------------------- -[//]: # (Please refer to https://github.com/MultiMC/MultiMC5/wiki/Log-Upload for instructions on how to attach your logs.) - - -Additional Info: ---------------------------- diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml new file mode 100644 index 00000000..7e894785 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -0,0 +1,52 @@ +name: Bug Report +description: File a bug report +labels: [bug, needs-triage] +issue_body: false +body: +- type: markdown + attributes: + value: | + If you need help with running Minecraft, please visit us [on our Discord](https://discord.gg/multimc) before making a bug report. + + Before submitting a bug report, please make sure you have read this *entire* form, and that: + * You have read the [FAQ](https://github.com/MultiMC/MultiMC5/wiki/FAQ) and it has not answered your question + * Your bug is not caused by Minecraft or any mods you have installed. + * Your issue has not been reported before, [make sure to use the search function!](https://github.com/MultiMC/MultiMC5/issues) + + **Do not forget to give your issue a descriptive title.** "Bug in the instance screen" makes it hard to distinguish issues at a glance. +- type: dropdown + attributes: + label: Operating System + description: If you know this bug occurs on multiple operating systems, select all you have tested. + multiple: true + options: + - Windows + - macOS + - Linux + - Other +- type: textarea + attributes: + label: Description of bug + description: What did you expect to happen, what happened, and why is it incorrect? + placeholder: The cat button should show a cat, but it showed a dog instead! + validations: + required: true +- type: textarea + attributes: + label: Steps to reproduce + description: A bulleted list, or an exported instance if relevant. + placeholder: "* Press the cat button" + validations: + required: true +- type: textarea + attributes: + label: Suspected cause + description: If you know what could be causing this bug, describe it here. + validations: + required: false +- type: checkboxes + attributes: + label: This issue is unique + options: + - label: I have searched the issue tracker and did not find an issue describing my bug. + required: true diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml new file mode 100644 index 00000000..089f1eb5 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -0,0 +1,5 @@ +blank_issues_enabled: true +contact_links: + - name: MultiMC Discord + url: https://discord.gg/multimc + about: Please ask for support here before opening an issue. diff --git a/.github/ISSUE_TEMPLATE/suggestion.yml b/.github/ISSUE_TEMPLATE/suggestion.yml new file mode 100644 index 00000000..ab2449a0 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/suggestion.yml @@ -0,0 +1,41 @@ +name: Suggestion +description: Make a suggestion +labels: [idea, needs-triage] +issue_body: true +body: +- type: markdown + attributes: + value: | + ### Use this form to suggest a feature for MultiMC. +- type: input + attributes: + label: Role + description: In what way do you use MultiMC that needs this feature? + placeholder: I play modded Minecraft. + validations: + required: true +- type: input + attributes: + label: Suggestion + description: What do you want MultiMC to do? + placeholder: I want the cat button to meow. + validations: + required: true +- type: input + attributes: + label: Benefit + description: Why do you need MultiMC to do this? + placeholder: so that I can always hear a cat when I need to. + validations: + required: true +- type: checkboxes + attributes: + label: This suggestion is unique + options: + - label: I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected. + required: true +- type: markdown + attributes: + value: | + ### You may use the editor below to elaborate further. +# The issue_body: true up there makes the standard WYSIWYG editor for issues show up down here. From fafeb4fa3e3bf6deff77e327cd295767b21048c2 Mon Sep 17 00:00:00 2001 From: Sebastian-byte Date: Wed, 24 Mar 2021 11:16:24 -0500 Subject: [PATCH 3/3] Add newline at end of file --- api/logic/minecraft/auth/AuthSession.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/logic/minecraft/auth/AuthSession.cpp b/api/logic/minecraft/auth/AuthSession.cpp index 1a6ab177..b2ea62c8 100644 --- a/api/logic/minecraft/auth/AuthSession.cpp +++ b/api/logic/minecraft/auth/AuthSession.cpp @@ -42,4 +42,4 @@ bool AuthSession::MakeCracked(QString offline_playername) player_name = offline_playername; status = PlayableOffline; return true; -} \ No newline at end of file +}