From 0a2ad17f062b42710d111e03567f1d1f08784f42 Mon Sep 17 00:00:00 2001 From: arthomnix Date: Sun, 3 Jul 2022 18:11:18 +0100 Subject: [PATCH] NOISSUE shortcut creation: add comments and todo --- launcher/ui/dialogs/CreateShortcutDialog.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/launcher/ui/dialogs/CreateShortcutDialog.cpp b/launcher/ui/dialogs/CreateShortcutDialog.cpp index 3dc91988..3238da01 100644 --- a/launcher/ui/dialogs/CreateShortcutDialog.cpp +++ b/launcher/ui/dialogs/CreateShortcutDialog.cpp @@ -41,6 +41,8 @@ CreateShortcutDialog::CreateShortcutDialog(QWidget *parent, InstancePtr instance ui->profileComboBox->setCurrentText(accounts->defaultAccount()->profileName()); } + // check if instance is affected by a bug causing it to crash when trying to join a server on launch + // TODO: implement this check in meta if (m_instance->typeName() == "Minecraft") { try @@ -64,6 +66,7 @@ CreateShortcutDialog::CreateShortcutDialog(QWidget *parent, InstancePtr instance } } + // Macs don't have any concept of a desktop shortcut, so force-enable the option to generate a shell script instead #if defined(Q_OS_UNIX) && !defined(Q_OS_LINUX) ui->createScriptCheckBox->setEnabled(false); ui->createScriptCheckBox->setChecked(true);